-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defusedxml deprecation warning #6
Comments
This patch removes the defusedxml usage and uses lxml istead. Closes carlwgeorge#6
Hi, are there any updates on this? We could just do this, right?: - import defusedxml.lxml
+ from defusedxml import ElementTree and replace |
Sorry, no update on this so far. I'm long overdue to do some maintenance work on this module, I just haven't gotten around to it yet. When I do I plan to just remove the defusedxml dependency entirely, as that upstream now believes that lxml is mostly safe. When I first wrote this module lxml was significantly faster than other methods, so I'd prefer to stick with it. |
@carlwgeorge Thank you for the quick reply. Would you accept a PR to use |
I appreciate the offer of a PR, but it's not necessary as I just need to revert this commit, which will be easy to do once I find time to work on this again. I do intend to keep using the lxml module because of the speed benefits, which are really needed for larger repositories. |
Running the tests currently results in a deprecation warning that wasn't there with previous versions of the dependencies.
This looks to be caused by tiran/defusedxml#38.
The text was updated successfully, but these errors were encountered: