Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic cleanup jobs for Github Teams and Users #1413

Open
danbrauer opened this issue Dec 20, 2024 · 0 comments
Open

Automatic cleanup jobs for Github Teams and Users #1413

danbrauer opened this issue Dec 20, 2024 · 0 comments

Comments

@danbrauer
Copy link
Contributor

Feature request template

Automatic cleanup jobs for Github Teams and Users

Description:

As mentioned by @achantavy in this slack thread among other places, Cartography wants to implement cleanup jobs for the following:

  • github teams and users:
    • the MEMBER_OF_TEAM relationship
    • the MEMBER relationship
    • the MAINTAINER relationship
  • github users and orgs
    • the ADMIN_OF relationship

Relevant Links:
achantavy added a commit that referenced this issue Dec 27, 2024
@achantavy
#1413: Support automatic cleanups for NodeSchemas without a sub resource
5645666 
Signed-off-by: Alex Chantavy <chantavy@gmail.com>
@achantavy achantavy mentioned this issue Dec 27, 2024
Merged
3 tasks
achantavy added a commit that referenced this issue Dec 29, 2024
@achantavy
#1413: Support automatic cleanups for NodeSchemas without a sub resou…
b41963b 
…rce (#1419)

### Summary
> Describe your changes.

#1413 

Removes a restriction so that cartography's data model can now
automatically clean up NodeSchemas that don't have a tenant
relationship.

In these cases, the nodes will not be deleted even if they are
considered stale, but their stale relationships will be.

We do it this way because cartography syncs assets one tenant at a time,
and stale nodes can only be safely deleted if they are tied to a tenant
so that we do not erroneously delete nodes attached to other tenants.

### Related issues or links
> Include links to relevant issues or other pages.
- #1413

We discussed this in the above issue but I'll summarize a bit here: in
the case of GitHub, GitHubUsers don't have a true "tenant" relationship
with their organization because they can exist independent of their
organizations. In this case, it makes sense for a GitHubUser to have a
node schema that does not have a tenant rel. If we want to list out all
of the users in an organization, then we simply query for the
organization and its attached users.


### Checklist

Provide proof that this works (this makes reviews move faster). Please
perform one or more of the following:
- [x] Update/add unit or integration tests.
- [ ] Include a screenshot showing what the graph looked like before and
after your changes.
- [ ] Include console log trace showing what happened before and after
your changes.

---------

Signed-off-by: Alex Chantavy <chantavy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danbrauer