-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential sadness if you find your domain in "boringDomains" config #8
Comments
valid critique and a good suggestion—I’ll tweak this in the coming days! thank you
… On 20 Mar 2022, at 21:24, decentral1se ***@***.***> wrote:
👋 r a d project 🥳
As an admin, it feels a bit uncomfortable putting domains into that config with such a name. The functionality is great & relevant but in a pubnix / shared server environment, other users might get wrong idea seeing the naming? If I'm trying to instead focus my search space on relevant links and not saying I think their stuff is "boring".
Proposal: skipDomains.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
|
I was about to start implementing this, but: For finding an alternative, there are a few reasons one would put a domain in this file:
The first two probably being the reason its current name is Some alternatives I considered are:
Another thing I considered is making it possible to add a comment on why something made it into the "boring" category. Usually explaining why something happened is better than trying to rename the mechanism. |
Yeh perhaps a bit of a bikeshed on the rename but I'd stil suggest to rename (whatever is good imo, for reasons above) + following your line of thought @slatian add some further documentation of the reasons for using this option. The name will probably always be a bit generic but the documentation can be very specific. That seems like a good compromise and will probably be a overall bonus for maintainers. |
Bravo!
|
That doesn't sound very respectful to me … The intention behind |
@slatian yes to documenting this more clearly / updating the docs when @decentral1se i thought they were referring to the file bannedDomains! boringDomains was indeed intended for filtering out boring stuff like facebook, instagram links etc etc :) |
👋 r a d project 🥳
As an admin, it feels a bit uncomfortable putting domains into that config with such a name. The functionality is great & relevant but in a pubnix / shared server environment, other users might get the wrong idea seeing the naming? If I'm trying to instead focus my search space on relevant links and not saying I think their stuff is "boring".
Proposal:
skipDomains
.The text was updated successfully, but these errors were encountered: