You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normally I would submit a pull request but if you see the other issue I filed (with the name change) then you can imagine that my pull request would look very odd. Pretty simple bug and fix.
The text was updated successfully, but these errors were encountered:
Strictly speaking the assembly produced by the current version of the code is likely the same as the assembly which would be created by the explicit return (since get_byte puts everything in the right location and the caller function pop_byte ends). Still worth fixing IMO.
Your pop_byte routine reads as follows:
There is no return here.
Normally I would submit a pull request but if you see the other issue I filed (with the name change) then you can imagine that my pull request would look very odd. Pretty simple bug and fix.
The text was updated successfully, but these errors were encountered: