-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bogus error message #3239
Comments
How can a single parse token be in more than one file? Could you provide a simpler example that showcases how this is even possible. This is important because it affects how roundtrip and linter processes the tree. VObject has only a single member to hold file reference. If the start and end can be in two different files, we have bigger issues to resolve than merely removing the reported error. |
Sorry, try to extract the example from black-parrot. Its your check. But before, try to debug the latest black-parrot from th original GitHub, not the snapshot in Surelog. |
Apparently, it's possible that the start and end file of a VObject token are different. One such case is when a include file is in the middle of a module declaration. Known Issue: VObject still needs to track the end file but there's only one PathId member which is tracking the start file. Something to follow up on.
@alaindargelas Please keep the issue open after you merge. I have merely commented out the check for now to unblock. I still need to follow up on how to handle this so we have the necessary information for the token. Let it be assigned to me. |
Issue #3239: Remove erroneous error reporting
@hs-apotell, thanks. |
@hs-apotell this new error message is incorrect:
Surelog/src/Design/FileContent.cpp
Line 689 in b4ad3fc
The testcase black-parrot has indeed statements that cross files (Due to includes).
Please remove that check. It is not compliant with Verilog proprocessing.
The issue is discussed here, it is a sub-issue of that case:
chipsalliance/synlig#1064 (comment)
The text was updated successfully, but these errors were encountered: