-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category inconsistent with paper on NC #19
Comments
Hi there, thanks for using mobileOG-db! I'm unclear what you are referring to here. The getElementClassifications.R script just creates a new file using the mobileOG-db metadata with classifications. As stated in the paper, proteins can be assigned to multiple classes (as in the figure on the tool readme page) if they are found in more than one database or meet more than one of those conditions. IOW, it is possible to have a protein that is labeled as a plasmid and insertion sequence, for example. please do send an example if this doesn't clear things up! |
Thanks for your quick and kind reply! For example, in the paper integrative elements were defined as sequences derived from ICEberg and integration/excision category proteins not included in ISfinder. When I tried to classify the MGEs with rule (sequences derived from integration/excision category proteins not included in ISfinder), some MGEs may be annotated with many database, such as phage and integrative elements, I konw it is OK according to your explaination. Thanks a lot!
|
Ah, nice catch! I suggest to follow the paper's - will push an update to the script shortly. |
Thank you for your answer and help. I wish you a joyful day every day. |
Hello,
I read the your paper published on Nature Coummunication recently and you mentioned that the script getElementClassifications.R (https://github.com/clb21565/mobileOGdb/blob/main/scripts/getElementClassifications.R) was used to classify MGEs.
In the paper, the MGEs were profiled by following rules:
MGE marker hits were subclassified into element classes of plasmid (sequences derived from COMPASS64 or NCBI Plasmid RefSeq65), transposable element (sequences derived from ISfinder66), integrative (sequences derived from ICEberg67 and integration/excision category proteins not included in ISfinder), or conjugative types (sequences with the transfer major mobileOG category and conjugation minor category) using the script getElementClassifications.R.
But in the getElementClassifications.R, the rules seemed to by inconsistent.
Could you help me to choose reasonable and right rules? Thanks for your help!
The text was updated successfully, but these errors were encountered: