diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b30a2d4..f76627f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,2 @@ -.github/* @clouddrove/approvers - -* @clouddrove/clouddrovians @clouddrove/approvers - -.github/mergify.yml @clouddrove/admins -.github/CODEOWNERS @clouddrove/admins +# These owners will be the default owners for everything in the repo. +* @anmolnagpal @clouddrove-ci @clouddrove/terraform-azure-admins \ No newline at end of file diff --git a/examples/complete/example.tf b/examples/complete/example.tf index 64edbf6..29a8867 100644 --- a/examples/complete/example.tf +++ b/examples/complete/example.tf @@ -76,23 +76,31 @@ module "log-analytics" { name = local.name environment = local.environment label_order = local.label_order - create_log_analytics_workspace = false + create_log_analytics_workspace = true # Set it 'false' if you don't want resource log-analytics workspace to be created log_analytics_workspace_sku = "PerGB2018" daily_quota_gb = "-1" internet_ingestion_enabled = true internet_query_enabled = true resource_group_name = module.resource_group.resource_group_name log_analytics_workspace_location = module.resource_group.resource_group_location + storage_account_id = module.storage.storage_account_id + diagnostic_setting_enable = false # Set it 'true' if you want azurerm_monitor_diagnostic_setting to be enabled + } ##----------------------------------------------------------------------------- ## Key Vault module call. ##----------------------------------------------------------------------------- module "vault" { + providers = { + azurerm.main_sub = azurerm + azurerm.dns_sub = azurerm.peer + } + source = "clouddrove/key-vault/azure" version = "1.1.0" - name = "vae5960581" + name = "vae59605811" environment = "test" label_order = ["name", "environment", ] resource_group_name = module.resource_group.resource_group_name diff --git a/main.tf b/main.tf index a3a1bed..8429e8b 100644 --- a/main.tf +++ b/main.tf @@ -29,7 +29,7 @@ resource "azurerm_storage_account" "storage" { account_tier = var.account_tier access_tier = var.access_tier account_replication_type = var.account_replication_type - https_traffic_only_enabled = var.https_traffic_only_enabled + https_traffic_only_enabled = var.enable_https_traffic_only min_tls_version = var.min_tls_version is_hns_enabled = var.is_hns_enabled sftp_enabled = var.sftp_enabled diff --git a/variables.tf b/variables.tf index 1ad063c..cfe4be6 100644 --- a/variables.tf +++ b/variables.tf @@ -78,7 +78,7 @@ variable "account_replication_type" { description = "Defines the type of replication to use for this storage account. Valid options are LRS, GRS, RAGRS, ZRS, GZRS and RAGZRS. Changing this forces a new resource to be created when types LRS, GRS and RAGRS are changed to ZRS, GZRS or RAGZRS and vice versa." } -variable "https_traffic_only_enabled" { +variable "enable_https_traffic_only" { type = bool default = true description = " Boolean flag which forces HTTPS if enabled, see here for more information."