From f0aec820fb068a8e5d1aaebfa17d4797a3346032 Mon Sep 17 00:00:00 2001 From: Ryan May Date: Mon, 18 Apr 2016 13:41:35 -0600 Subject: [PATCH 1/2] Try to clarify selector message (Fixes #136) Explicitly spell out the numbers of spaces since it's just not clear in the messages. --- conda_smithy/lint_recipe.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conda_smithy/lint_recipe.py b/conda_smithy/lint_recipe.py index dd7ce50ec..e431a0701 100644 --- a/conda_smithy/lint_recipe.py +++ b/conda_smithy/lint_recipe.py @@ -85,7 +85,7 @@ def lintify(meta, recipe_dir=None): bad_selectors.append(selector_line) if bad_selectors: lints.append('Selectors are suggested to take a ' - '" # []" form.') + '"#[]" form.') # 7: The build section should have a build number. if build_section.get('number', None) is None: From d91885f74a696e7316e8b427b99eeb246957e8ae Mon Sep 17 00:00:00 2001 From: Phil Elson Date: Tue, 19 Apr 2016 14:03:34 +0100 Subject: [PATCH 2/2] Improve the message, and fix the test, for the selector lint. --- conda_smithy/lint_recipe.py | 2 +- conda_smithy/tests/test_lint_recipe.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/conda_smithy/lint_recipe.py b/conda_smithy/lint_recipe.py index e431a0701..d1a3d2048 100644 --- a/conda_smithy/lint_recipe.py +++ b/conda_smithy/lint_recipe.py @@ -85,7 +85,7 @@ def lintify(meta, recipe_dir=None): bad_selectors.append(selector_line) if bad_selectors: lints.append('Selectors are suggested to take a ' - '"#[]" form.') + '``#[]`` form.') # 7: The build section should have a build number. if build_section.get('number', None) is None: diff --git a/conda_smithy/tests/test_lint_recipe.py b/conda_smithy/tests/test_lint_recipe.py index 25b7349d3..6e30131ae 100644 --- a/conda_smithy/tests/test_lint_recipe.py +++ b/conda_smithy/tests/test_lint_recipe.py @@ -111,7 +111,7 @@ def test_test_section_with_recipe(self): def test_selectors(self): expected_message = ('Selectors are suggested to take a ' - '" # []" form.') + '``#[]`` form.') with tmp_directory() as recipe_dir: def assert_selector(selector, is_good=True):