Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed migrators not removed from conda-smithy's cache #1833

Open
jakirkham opened this issue Jan 19, 2024 · 6 comments
Open

Closed migrators not removed from conda-smithy's cache #1833

jakirkham opened this issue Jan 19, 2024 · 6 comments
Labels

Comments

@jakirkham
Copy link
Member

When a migrator is closed, conda-smithy still hangs onto the migrator in cache and doesn't remove it. As a result re-rendering locally can leave closed migrators in

One possible fix would be for conda-smithy to recheck its cache contents against the migrator source and remove any that are no longer included upstream

@jakirkham
Copy link
Member Author

jakirkham commented Jan 20, 2024

Maybe this would make sense to do as part of this cache refreshing step

def get_cfp_file_path(temporary_directory):

@jakirkham
Copy link
Member Author

A workaround for this would be to purge the local migrator cache and try again

For my system, this looks like...

rm -rf ~/.cache/conda-smithy/share/conda-forge/migrations

@jdblischak
Copy link
Member

I do a lot of local rerendering, so this bug has caused me a lot of confusion. Is there any way we can prioritize fixing this? It is disorienting when the local rerendering doesn't match the bot's rerendering. I know I can simply delete the local cache, but that is exactly the thing I will forget to remember to do when I am in a hurry.

xref: conda-forge/tiledb-feedstock#298 (comment), conda-forge/tiledb-feedstock#296 (comment)

Also note that deleting ~/.cache/conda-smithy/share/conda-forge/migrations was insufficient to fix the problem for me. I had to delete ~/.cache/conda-smithy/ entirely for conda-smithy to delete the old migration files. For details please see conda-forge/tiledb-feedstock#298 (comment)

@isuruf
Copy link
Member

isuruf commented Jun 13, 2024

PRs welcome. You probably need to delete the folder at

get_cfp_file_path(smithy_cache)

@corneliusroemer
Copy link
Member

@jakirkham what did you mean to end this sentence with?

When a migrator is closed, conda-smithy still hangs onto the migrator in cache and doesn't remove it. As a result re-rendering locally can leave closed migrators in

In what are the closed migrators left?

I noticed smithy hung in this codepath, which made me create #1972 - not sure if this is related or not.

@jdblischak
Copy link
Member

In what are the closed migrators left?

In the local cache directory, which on Ubuntu is ~/.cache/conda-smithy/share/conda-forge/migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants