Linting conda-forge.yml does not diagnose (some) schema violations

[h-vetinari]

The following file as conda-forge.yml yields a clean slate from the linter

build_platform:
  wrong: a
os_version:
  wrong: b
provider:
  wrong: c

despite the fact that, based on schema.py (or at least the obvious intent there), it should fail:

conda-smithy/conda_smithy/schema.py

Lines 548 to 563 in 2b18d8d

	BuildPlatform = create_model(
	"build_platform",
	**{
	platform.value: (Optional[Platforms], Field(default=platform.value))
	for platform in Platforms
	},
	)
	OSVersion = create_model(
	"os_version",
	**{
	platform.value: (Optional[Union[str, Nullable]], Field(default=None))
	for platform in Platforms
	if platform.value.startswith("linux")
	},
	)

All three of those are using pydantic's create_model, which I presume is not working as intended here.

[h-vetinari]

With an addition of ConfigDict(extra='forbid'), I can get the following

from conda.base.constants import KNOWN_SUBDIRS
from pydantic import ConfigDict, Field, create_model
from enum import StrEnum

dirs = [subdir.replace("-", "_") for subdir in KNOWN_SUBDIRS if "-" in subdir]
Platforms = StrEnum("Platforms", dirs)

BuildPlatform = create_model(
    "build_platform",
    __config__=ConfigDict(extra='forbid'),
    **{
        platform.value: (Platforms, Field(default=platform.value))
        for platform in Platforms
    },
)

to yield

>>> BuildPlatform(wrong="linux_64")
pydantic_core._pydantic_core.ValidationError: 1 validation error for build_platform
wrong
  Extra inputs are not permitted [type=extra_forbidden, input_value='linux_64', input_type=str]
    For further information visit https://errors.pydantic.dev/2.9/v/extra_forbidden

However, if I add ConfigDict(extra='forbid') to schema.py and lint an affected recipe, nothing triggers. 🤔

[h-vetinari]

I found that the work for this has already been done by @ytausch in #1920. I merged main in that PR and verified that it correctly diagnoses wrong values (as hints), and with a pretty nice message too:

recipe has some suggestions:
  Unexpected key build_platform.wrong
  Unexpected key os_version.wrong
  Unexpected key provider.wrong