-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat
is contracted, most other commonly used tags are full words.
#544
Comments
feat
is contracted, all other tags are full words. feat
is contracted, most other commonly used tags are full words.
Very thoughtful , even in verbal communication while pair programming or while guiding juniors so it's great idea to make it complete thank you , have a nice day |
The dictionary explains what
So it can be confused with |
|
The proposed change adds 3 characters to the commit header (thereby substracting them from the commit subject, if one wants to keep it below 72 characters). Those 3 characters are precious, particularly for languages other than English where it's already difficult to fit such limit. I would rather keep |
In that case go with:
Or, remove the prefix completely from the commit, knowing that the branch the commit is in, already has that prefix anyway, so why repeat yourself? And then, on the squash commit - put that prefix in (which will automatically be added anyway from the PR title) and there will still be a description in the separate lines of the commit message. Regardless of your or my preferences, the |
@javier-godoy How about |
|
Claro 👍 |
Precious characters, indeed. Precious language, nonetheless. I'd vote for full words (i.e. "feature"). I didn't know that "feat" is a word, though. |
In the most common use of this spec the terms are almost always full words, with two exceptions
feat
andperf
Suggest retiring
feat
andperf
and replace withfeature
andperformance
for consistency.perf
is outside the scope of this repo though.Rationale
Searching for
feature
in commit messages using this spec won't return commits using the termfeature
, which is a reasonable commit message to add a feature.The text was updated successfully, but these errors were encountered: