Skip to content

Latest commit

 

History

History
92 lines (60 loc) · 5.13 KB

CONTRIBUTING.md

File metadata and controls

92 lines (60 loc) · 5.13 KB
Raw

Contributing to Saladict

👍🎉 First off, thanks for taking the time to contribute! 🎉👍

How to Contribute

⚠️ Unless it is a small hot fix, before you write any code and get your hands dirty, please open an issue or make a WIP pull request to elaborate what you are trying to do and how you are going to implement it. Just to make sure we are on the same page and nobody's time and effort are wasted.

How to get started

git clone git@github.com:crimx/ext-saladict.git
cd ext-saladict
yarn install
yarn pdf

Add a .env file following the .env.example format(leave empty if you don't use these dictionaries).

UI Tweaking

Run yarn fixtures to download fixtures(only need to run once).

Run yarn storybook to view all the components.

Run yarn start --wextentry [entry id] to view a certain entry with WDS in a fake WebExtension environment.

Testing

Run yarn test to run Jest. Supports all the Jest options.

Building

Run yarn build to start a full build.

Toggle:

  • --debug: Remove compression and generate sourcemaps.
  • --analyze: Show detailed Webpack bundle analyzer.

How to add a dictionary

For safety and maintainability reason, Saladict will not support adding dictionaries on the fly. All dictionaries must be merged to this project via pull requests.

If dictionary implementation makes use of private API please move it to an independent project, release on NPM, then import it to Saladict.

  1. Create a directory at src/components/dictionaries/, with the name of the dict ID.
    1. Use any existing dictionary as guidance, e.g. Bing. Copy files to the new directory.
    2. Replace the favicon with a new LOGO.
    3. Edit config.ts to change default options. See the DictItem type and explanation for more details. Register the dictionary in app config so that TypeScript generates the correct typings. Dict ID MUST follow alphabetical order.
    4. Update _locales.json with the new dictionary name. Add locales for options, if any.
    5. engine.ts MUST export at least two functions:
      1. getSrcPage function which is responsible for generating source page url base on search text and app config. Source page url is opened when user clicks the dictionary title.
      2. search function which is responsible for fetching, parsing and returning dictionary results. See the typings for more detail.
        • Extracting information from a webpage MUST use helper functions in ../helpers.ts for data cleansing.
        • If the dictionary supports pronunciation:
          1. Register the ID at config.autopron.
          2. Include an audio field in the object which search engine returns.
      3. Other exported functions can be called from View.tsx via 'DICT_ENGINE_METHOD' message channel. See src/typings/message for typing details and search DICT_ENGINE_METHOD project-wise for examples. Messages MUST be sent via message from '@/_helpers/browser-api' instead of the native sendMessage function.
    6. Search result will ultimately be passed to a React PureComponent in View.tsx, which SHOULD be a dumb component that renders the result accordingly.
    7. Selectors in _style.scss SHOULD follow ECSS-ish naming convention.

Develop the dictionary UI live

To develop the component in Storybook we need to intercept http requests from dictionary engines and replace with the downloaded results.

  1. Add fixtures.js at test/specs/components/dictionaries/[dictID].
    • See other dictionaries for example.
    • You can offer url or axios config (See mojidict dictionary). All results from previous requests will be passed to the next request as array.
  2. Run yarn fixtures to download fixtures.
  3. Edit test/specs/components/dictionaries/[dictID]/request.mock.ts. It will intercept requests and return the downloaded fixtures.
  4. Run yarn storybook.

Add Testing

  1. Add [dictID]/engine.spec.ts to test the engine.

Code Style

This project follows the TypeScript variation of Standard JavaScript code style.

If you are using IDEs like VSCode, make sure eslint and prettier plugins are installed. Or you can just run building command to perform a TypeScript full check.

Commit Style

This project follows conventional commit style.

You can run yarn commit and follow the instructions, or use VSCode Conventional Commits extension in VSCode.