"Save & Go to Next Form" breaks with 2+ users

[aanunez]

Howdy,

I previously submitted this issue to the redcap devs believing it was a core issue, but after experimenting it would seem that the problem stems from your EM's override of the "Save & Go to Next Form" button. When two users have created a new record and are entering data in the first instrument (i.e. both have Record 1 assigned to them) the one who hits "Save & Go to Next Form" first is, of course, correctly taken to Form 2 for Record 1. However, when the second person hits "Save & Go to Next Form" they too are taken to From 2 for Record 1.

Previous submission (redcap login of course):
https://community.projectredcap.org/questions/76216/record-id-not-updated-when-using-save-and-go-to-ne.html

I haven't been able to look over the code and suggest a fix.

Version 3.3.10
Redcap 9.5.3

[pbchase]

@aanunez, what's up with this issue. Did you find a fix?

[aanunez]

It looks like I closed this by mistake as I know this was a real issue. Re-opening. So the issue happens because we assume that the $record passed into loadFRSL is our assigned recordID, but it might not be. We can check to see if the record really exists with

$existingRecord = !empty( REDCap::getData( $Proj->project_id ,"array", $record, REDCap::getRecordIdField() ) ) (maybe there is a better way to do this?)

and pass it down to the js, but I'm not sure what action is best if its non-existent record.

[pbchase]

@aanunez, want to submit a PR?

[NikNakk]

I think I've fixed the issue by using the 'auto' parameter during the redirect (see commit above). I've just tested it briefly and it seems to work. Note this problem can be triggered by a single user creating two records at once; it doesn't need a second user to be involved.

I've committed this to a branch that should also fix #57, but I've actually fixed the two issues independently of each other. The commit referenced above is specific to this issue.