Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calyx_depth.py: divest from odgi's Python bindings #107

Open
1 of 3 tasks
Tracked by #105
anshumanmohan opened this issue Jun 19, 2023 · 1 comment
Open
1 of 3 tasks
Tracked by #105

calyx_depth.py: divest from odgi's Python bindings #107

anshumanmohan opened this issue Jun 19, 2023 · 1 comment
Labels
feature New feature, or a meaningful extension to an existing feature

Comments

@anshumanmohan
Copy link
Contributor

anshumanmohan commented Jun 19, 2023

The algorithm calls parse_data.py, which in turn calls odgi's Python bindings, to learn the input graph's dimensions. Instead, use mygfa.preprocess:

def get_maxes(graph: mygfa.Graph) -> Tuple[int, int, int]:
"""Return the maximum number of nodes, steps, and paths in the graph."""
max_nodes = len(graph.segments)
max_steps = max([len(steps) for steps in node_steps(graph).values()])
max_paths = len(graph.paths)
return max_nodes, max_steps, max_paths

This will free us from odgi's Python bindings.

This work has been broken down as such:

For context, see tracking issue #105

@anshumanmohan anshumanmohan changed the title Instead of calling parse_data.py to learn the input graph's dimensions, use mygfa.preprocess. This will free us from odgi's Python bindings. calyx_depth.py: divest from odgi's Python bindings Jun 19, 2023
@anshumanmohan anshumanmohan added triage required Ideas that need further discussion, whether asynchronous or synchronous, before we can take action and removed triage required Ideas that need further discussion, whether asynchronous or synchronous, before we can take action labels Jun 20, 2023
@sampsyo
Copy link
Collaborator

sampsyo commented Jun 24, 2023

Yay; this would be very satisfying!!

@anshumanmohan anshumanmohan added feature New feature, or a meaningful extension to an existing feature and removed triage required Ideas that need further discussion, whether asynchronous or synchronous, before we can take action labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, or a meaningful extension to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants