Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened to the 3.0 branch of package:collection? #729

Open
nex3 opened this issue Dec 2, 2024 · 3 comments
Open

What happened to the 3.0 branch of package:collection? #729

nex3 opened this issue Dec 2, 2024 · 3 comments

Comments

@nex3
Copy link
Member

nex3 commented Dec 2, 2024

I landed dart-archive/collection#289 a while ago, but with the move to core it seems like neither the code nor the branch it was landed on made the move. Where did it end up? Can we get it merged into the main branch at some point?

@mit-mit
Copy link
Member

mit-mit commented Dec 3, 2024

@lrhn @devoncarew either of you know? Looks like a bunch of relevant changes: https://github.com/dart-archive/collection/compare/master...3.0?expand=1

@mit-mit mit-mit changed the title What happened to the 3.0 branch? What happened to the 3.0 branch of package:collection? Dec 3, 2024
@devoncarew
Copy link
Member

It looks like this branch might have been forgotten about. I see work landing in master around the same time - an alternative version of 1.18.0: dart-archive/collection@f949b09.

Both the stable version and this branch now require 3.0. I don't see breaking changes in there, so I don't think there would be issues w/ just re-landing these changes. cc @natebosch

@lrhn
Copy link
Member

lrhn commented Dec 9, 2024

Not completely forgotten, but "deprioritized" by other things. I'll try to put it closer to the top of the list.
(Next year!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants