Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid vm isolate snapshot seen when running webdev e2e_test.dart on Windows #59784

Open
bkonyi opened this issue Dec 20, 2024 · 0 comments
Open

Invalid vm isolate snapshot seen when running webdev e2e_test.dart on Windows #59784

bkonyi opened this issue Dec 20, 2024 · 0 comments
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Dec 20, 2024 •
edited
Loading

After 08252fc we've started seeing the Invalid vm isolate snapshot seen for webdev's e2e_test.dart on Windows. Based on a quick look, the VM isolate apparently is missing its magic number.
@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team labels Dec 20, 2024
copybara-service bot pushed a commit that referenced this issue Dec 20, 2024
@bkonyi
Revert "Fix Fuchsia build error."
7a5174a 
This reverts commit c5c3544.

Reason for revert: #59784

Original change's description:
> Fix Fuchsia build error.
>
> TEST=ci
>
> Change-Id: I31c160770bea6ba03fe3ca76545c37ffec94e44e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401483
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Brian Quinlan <bquinlan@google.com>

Change-Id: I302d407a5063a1989d05605e01da71913a8742e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401902
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 20, 2024
@bkonyi
Revert "[dartdev] Use VmInteropHandler for invoking sub commands"
7783e61 
This reverts commit 08252fc.

Reason for revert: #59784

Original change's description:
> [dartdev] Use VmInteropHandler for invoking sub commands
>
> Use VmInteropHandler for invoking sub commands instead of running them
> in an isolate. Running sub commands in an isolate causes an increased footprint.
> Changing this to use VmInteropHandler avoids the additional memory footprint.
>
> Commands that need to use an AOT runtime for execution now exec the AOT
> runtime and run the command.
>
> TEST=ci
>
> Change-Id: If7aed1cab2fec9d9940bd562ad5aa9c4e9a6ac7f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398604
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Brian Quinlan <bquinlan@google.com>
> Commit-Queue: Siva Annamalai <asiva@google.com>

Change-Id: I82a997d49a7d52e1fdaa7d75f509603ebe5e51dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401901
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-siva @bkonyi