Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add the UseASubscriptionInAJsEvent page to the FAQs menu in the docs #756

Closed
bpringe opened this issue Jun 2, 2022 · 1 comment
Closed

[Enhancement]: Add the UseASubscriptionInAJsEvent page to the FAQs menu in the docs #756

bpringe opened this issue Jun 2, 2022 · 1 comment
Assignees
@kimo-k
Labels
enhancement

Comments

@bpringe
Copy link
Contributor

bpringe commented Jun 2, 2022 •
edited
Loading

I've seen a warning recently with a link to this page, and noticed it's not linked from the FAQs page in the docs. I only got to it by manually navigating to the URL from the warning. Should this page be linked from the FAQs page?

The URL:
https://day8.github.io/re-frame/FAQs/UseASubscriptionInAJsEvent/

The warning:
image

Note: The second URL in the warning is linked from the FAQs page, but the first one is not.
@dannyfreeman
Copy link
Contributor

This PR would remove the warning: #754

@kimo-k kimo-k self-assigned this Jul 30, 2023
@kimo-k kimo-k closed this as completed in 68a5e9a Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimo-k kimo-k

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dannyfreeman @bpringe @kimo-k