Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1385] [CT-1381] [Feature] Improved Lineage DAG Layout #330

Closed
3 tasks done
mkleinbort-ic opened this issue Oct 21, 2022 · 4 comments
Closed
3 tasks done

[CT-1385] [CT-1381] [Feature] Improved Lineage DAG Layout #330

mkleinbort-ic opened this issue Oct 21, 2022 · 4 comments
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors Stale triage

Comments

@mkleinbort-ic
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

I propose 2 features:

Pinned x-coordinate ranges for nodes in the Dag
Minimized cross overs when deciding the y-coordinate of models.

In my view the x-coordinate would be the best way to view layers.

For example, consider a DAG with 4 layers:

  • Layer 1: Sources & Seeds
  • Layer 2: Bronze
  • Layer 3: Silver
  • Layer 4: Gold

I'd want no layer 1 node to be to the right of a layer 2 node, etc...

With regards to minimizing edge crossings. I know this is hard (NP Hard), but I think dot and similar tools do a pretty good job. See https://docs.google.com/viewer?url=http://www.graphviz.org/pdf/dotguide.pdf

Describe alternatives you've considered

I considered exporting the DAG file and visualizing it myself

Who will this benefit?

Anyone who uses the DAG as a form of troubleshooting/documentation

Are you interested in contributing this feature?

No, I don't know JS

Anything else?

No response

@mkleinbort-ic mkleinbort-ic added enhancement New feature or request triage labels Oct 21, 2022
@github-actions github-actions bot changed the title [Feature] Improved Lineage DAG Layout [CT-1381] [Feature] Improved Lineage DAG Layout Oct 21, 2022
@lostmygithubaccount
Copy link

thanks for opening @mkleinbort-ic! agree with improvements in this area in general, but it's likely not something we'll prioritize in the near future. going to transfer this to our dbt-docs repository and adjust the labels accordingly

@lostmygithubaccount lostmygithubaccount transferred this issue from dbt-labs/dbt-core Oct 23, 2022
@github-actions github-actions bot changed the title [CT-1381] [Feature] Improved Lineage DAG Layout [CT-1385] [CT-1381] [Feature] Improved Lineage DAG Layout Oct 23, 2022
@lostmygithubaccount lostmygithubaccount added help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors and removed triage labels Oct 23, 2022
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 19, 2023
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@polmonso
Copy link

polmonso commented Aug 5, 2024

Since dbt best practices recommends this layering, it would be very useful to see it in the docs. I'd love to re-open this feature request.

@github-actions github-actions bot added the triage label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors Stale triage
Projects
None yet
Development

No branches or pull requests

3 participants