Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxbuy/maxsell: take redemption fees into account #3125

Open
norwnd opened this issue Dec 21, 2024 · 0 comments
Open

maxbuy/maxsell: take redemption fees into account #3125

norwnd opened this issue Dec 21, 2024 · 0 comments

Comments

@norwnd
Copy link
Contributor

norwnd commented Dec 21, 2024

It seems when maxbuy/maxsell is calculated only swap fee is taken into account (but not redemption fee) as a "limiting factor",

namely when I try to place limit order of size N (where N is the value maxsell shows) on DCR-USDC market my request gets rejected with error message along the lines of "attempting to lock more polygon for redemption that is currently available. 4x > x" (presumably because I don't have enough POL to actually redeem the trade of size N),

I guess this is only relevant to validate for account-based assets (since for assets such as DCR and BTC you can pay any fees you need subtracting it from the funds you receive as redemption beneficiary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant