Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved automata not loading #54

Closed
gregth opened this issue Apr 18, 2016 · 5 comments
Closed

Saved automata not loading #54

gregth opened this issue Apr 18, 2016 · 5 comments

Comments

@gregth
Copy link

gregth commented Apr 18, 2016

Trying to load saved automata (using share links) is working inproperly. Specifically, sometimes it takes too much time to load the saved NFA and sometimes it doesn't even load it at all.

Example link of saved NFA: http://automata.discrete.gr/##v70

@vasspilka
Copy link
Collaborator

vasspilka commented Apr 18, 2016

Try removing the extra # the the link is sometimes parsed wrong and adds an extra # where there should be none.

http://automata.discrete.gr/#v70

Cheers

@gregth
Copy link
Author

gregth commented Apr 18, 2016

The generated links contain a double #. Removing the extra # doesn't seem
to be the solution to the problem. Actually it would seem a good idea the
generated links not to contain a double #, but still I think it has nothing
to do with the initial problem.

On Mon, Apr 18, 2016, 5:58 PM Vasilis Spilka notifications@github.com
wrote:

Try removing the extra #

http://automata.discrete.gr/#v70


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#54 (comment)

@vasspilka
Copy link
Collaborator

vasspilka commented Apr 18, 2016

A PR will be much appreciated :)

Here is what needs to be changed
https://github.com/dionyziz/Automata/blob/master/site/js/ui.js#L43

@vasspilka
Copy link
Collaborator

vasspilka commented Apr 18, 2016

My guess would be that if the link contains ONLY a # instead of #v it will add that extra #, also if anything else for that matter for example #123bebebe
:D

So the automaton is not loading when the "url" is wrong like the one you initially shared.
The reason it is slow is that it has to render the automaton locally through javascript, so if the automaton is complex it will take some time, a solution would be a loading animation, this way the the behavior is what would be expected.

@vasspilka
Copy link
Collaborator

Closing in favor of #55 and #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants