Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-ship checklist #12

Open
18 of 31 tasks
dmarx opened this issue Dec 10, 2023 · 0 comments
Open
18 of 31 tasks

pre-ship checklist #12

dmarx opened this issue Dec 10, 2023 · 0 comments

Comments

@dmarx
Copy link
Owner

dmarx commented Dec 10, 2023

Features

  • node which facilitates combining and normalizing lots of conds/curves for the user

    • combine manny
    • [ ] combine many and normalize
  • arithmetic reductions (sum, prod) that take more than 2 inputs

  • ensure we have a satisfactory install sequence.

    • i think right now the dependencies are just in requirements.txt. check other nodes for best practice install sequence
  • drawing functionality for schedules

  • node to collect several curves into a single pgroup

  • pgroup vs curve arithmetic

  • pgroup reductions (broken upstream?)

    • sum over pgroup
    • prod over pgroup

Bugs

  • cond addition is not order invariant and changing order can result in undercooked/deepfried animations
    • sprinkle deepcopy around core.py nodes
  • interpolators not working on schedule
    • exp_decay - missing parameter
    • sine_wave - throws error on a division operation

documentation

  • screenshots of new nodes in readme
    • parameter group stuff
    • drawing utilities
  • update workflow images for aliased names and new nodes
  • add demo for superposition with utility nodes
  • link out from keyframed to comyui-keyframed
    • do a release of keyframed as well. low hanging fruit: add total_ordering to Keyframed class
  • expand curve drawing demo
    • add yaml-initialized fancy curve to drawing demo
    • sinusoidal
    • superposition
    • different interpolators
    • LFOs (once those are a thing)

Scope Creep (move to next release

  • LFOs
  • combine many and normalize
  • 1-x operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant