Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature method to ImagePruner that cleans up the dangling images #12395

Open
DanielPickens opened this issue Dec 17, 2024 · 0 comments
Open

Comments

@DanielPickens
Copy link

DanielPickens commented Dec 17, 2024

Description

Add new feature method to ImagePruner that cleans up the dangling images as well (historically we have NOT) and the feature would add handler method to gracefully (without producing confusing CLI output,) i.e. handle the output of a callback that would not print out a bunch of untagged/dangling image IDs and they should be grouped into a logical operation for the relevant service

Why is this needed:

This would fix the low hanging fruit of the func (p *ImagePruner) not handling dangling images with multiple inherited operators, and the feature would handle the dangling images in func (p *ImagePruner) rather than group the untagged/dangled images in a non-logical order operation.

What would you like to be added:
Update the arguement configurations and handler logic to appropriate configurations needed to add the handler method gracefully without producing confusing cli output from misdangled and unappropriated logical operands running in the function, but rather handles them gracefully in a way that they are modeling an inheritance factor that adds simplicity and grace to the handler method, such as using frameworks as a grouping method into a logical operation, so as the images from ImagePruner are not dangling, causing any confusing output index fields:

func (p *ImagePruner) labeledLocalImages(ctx context.Context) ([]image.Summary, error) {
	imageListOpts := image.ListOptions{
		Filters: filters.NewArgs(
			projectFilter(p.project.Name),
			
                      //add method here

			filters.Arg("dangling", "false"),
		),
	}

Who is this feature for?
@docker/compose/api
@docker/api/types/image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant