Why not use a .env file and move variables from docker-compose.yml to the .env file?

[ovizii]

Currently, the docker-compose.yml sample contains stuff like:

    environment:
      FORCE_SSL: 'true'
      DATABASE_URL: postgresql://postgres:postgres@postgres:5432/docuseal

  postgres:
    image: postgres:latest
    volumes:
      - './pg_data:/var/lib/postgresql/data'
    environment:
      POSTGRES_USER: postgres
      POSTGRES_PASSWORD: postgres
      POSTGRES_DB: docuseal

why don't we use a .env like:

POSTGRES_USER=postgres
POSTGRES_PASSWORD=secretpassword
POSTGRES_DB=docuseal
POSTGRES_HOST=docuseal-db
POSTGRES_PORT=5432

and then reference those variables inside docker-compose.yml like:

    environment:
      FORCE_SSL: 'true'
      DATABASE_URL: postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${POSTGRES_HOST}:${POSTGRES_PORT}/${POSTGRES_DB}

    environment:
      POSTGRES_USER: ${POSTGRES_USER}
      POSTGRES_PASSWORD: ${POSTGRES_PASSWORD}
      POSTGRES_DB: ${POSTGRES_DB}
      POSTGRES_HOST: ${POSTGRES_HOST}
      POSTGRES_PORT: ${POSTGRES_PORT}

[AlexBTurchyn]

@ovizii There is no point of doing this in docker compose - afaik all containers created via docker compose are sharing an issolated network that can't be accessed from outside. So adding custom database env variables won't make your setup more secure. But requiring those variables will cause more friction for the users and will make it harder to self-host the tool.

[ovizii]

I understand, thanks for explaining. I will keep this for my installation though as I found it bothersome having to copy/paste all those variables I defined to put them together for the DATABASE_URL.