Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Modify datetime of files in libpam4j.jar are "1980-02-01 00:00" #24578

Open
zsuiqiang opened this issue Sep 7, 2023 · 5 comments
Open

All Modify datetime of files in libpam4j.jar are "1980-02-01 00:00" #24578

zsuiqiang opened this issue Sep 7, 2023 · 5 comments

Comments

@zsuiqiang
Copy link

zsuiqiang commented Sep 7, 2023

Environment Details

  • GlassFish Version (and build number):7.0.8
  • JDK version:17
  • OS:windows 11
  • Database:

Problem Description

All Modify datetime of files in libpam4j.jar are "1980-02-01 00:00"

@dmatej
Copy link
Contributor

dmatej commented Sep 7, 2023

I can confirm that, despite I don't see it as an issue I would like to know the explanation :-)
It seems it is the target now - reproducible builds, we already have several PRs waiting here. The libpam is packaged by maven bundle plugin which already supports reproducible builds, so it sets these timestamps to zero.

https://maven.apache.org/guides/mini/guide-reproducible-builds.html
FasterXML/jackson-databind#3680 - this would be a workaround, the question is what we really want (originally I was against these changes, but I was convinced).

@zsuiqiang
Copy link
Author

This causes JNA to be unavailable。See Custom JNA Library Version Support #24358

@dmatej
Copy link
Contributor

dmatej commented Sep 11, 2023

This causes JNA to be unavailable。See Custom JNA Library Version Support #24358

I doubt it is caused by this - GF doesn't use file creation/update dates at all. It must be something else.

@pzygielo
Copy link
Contributor

The libpam is packaged by maven bundle plugin which already supports reproducible builds, so it sets these timestamps to zero.

Just to clarify the value of "zero": https://bnd.bndtools.org/releases/6.1.0/instructions/reproducible.html

FasterXML/jackson-databind#3680
this would be a workaround,

the question is what we really want

The reproducer I guess. Otherwise I see no issue against GF reported here.

Copy link

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

@github-actions github-actions bot added the Stale label Sep 11, 2024
@avpinchuk avpinchuk removed the Stale label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants