Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES module + named exports #242

Open
leomp12 opened this issue Sep 15, 2022 · 0 comments
Open

ES module + named exports #242

leomp12 opened this issue Sep 15, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@leomp12
Copy link
Member

leomp12 commented Sep 15, 2022

Named export 'img' not found. The requested module '@ecomplus/utils' is a CommonJS module, which may not support all module.exports as named exports.

https://github.com/ecomplus/store/actions/runs/3064321753/jobs/4947313663

🙃
@leomp12 leomp12 added enhancement New feature or request help wanted Extra attention is needed and removed enhancement New feature or request labels Sep 15, 2022
@leomp12 leomp12 changed the title Module + named exports ES module + named exports Sep 15, 2022
leomp12 added a commit to ecomplus/cloud-commerce that referenced this issue Sep 15, 2022
@leomp12
fix(storefront): Cant use named imports from @ecomplus/utils yet
d35a839 
CC https://github.com/ecomplus/store/actions/runs/3064321753/jobs/4947313663 > ecomplus/utils#242
leomp12 added a commit that referenced this issue Nov 9, 2022
@leomp12
fix(esm): add pkg conditional exports and type module [#242]
b0f836c 
rename config/build files to .cjs
leomp12 added a commit that referenced this issue Nov 10, 2022
@leomp12
build: build esm to dist with fixed imports and mjs extension [#242]
dde17b8
leomp12 added a commit that referenced this issue Nov 10, 2022
@leomp12
build: fix esm build import with line break [#242]
e23e09e 
fixes "Cannot find module **/constants from **/config.mjs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leomp12