Handle both JSON request bodies as well as CBOR request bodies.

[akramtexas]

• Currently, we do not check the header value (i.e. whether ContentType is JSON or CBOR). Creating this functionality will be helpful and can be used in the future when such functionality possibly becomes a requisite.
• This functionality has actually already been largely addressed, as part of some CBOR-related work done in the edgex-go repo, so there is no need to start from scratch.
• More details can be found on the following feature branch: Functionality largely addressed.
• Mentioning the following snippet for reference:

func parseParams(params string, r *http.Request) (paramMap map[string]string, err error) {

  if r == nil {
    return nil, fmt.Errorf("error in request parameter that was passed in")
  }

  // Check the header value
  switch r.Header.Get(clients.ContentType) {
  case clients.ContentTypeCBOR:
    err = codec.NewDecoderBytes([]byte(params), &codec.CborHandle{}).Decode(&paramMap)
  case clients.ContentTypeJSON:
    err = json.Unmarshal([]byte(params), &paramMap)
  default:
    common.LoggingClient.Error(fmt.Sprintf("header value was neither JSON nor CBOR, instead was: %s", r.Header.Get(clients.ContentType)))
  }

  if err != nil {
    common.LoggingClient.Error(fmt.Sprintf("parsing Write parameters failed %s, %v", params, err))
    return
  }

  if len(paramMap) == 0 {
    err = fmt.Errorf("no parameters specified")
    return
  }
  return
}

[cloudxxx8]

@FelixTing could you please verify this issue? thanks

[FelixTing]

Hi @cloudxxx8, yes, I tested a get binary command with device-virtual and the response header is correct. And we do need to handle request bodies according to the ContentType value in header. https://github.com/edgexfoundry/device-sdk-go/blob/master/internal/handler/command.go#L414

[cloudxxx8]

The related document has been addressed in edgexfoundry/edgex-docs#118

[chr1shung]

v2 binary handling is under discussion

[cloudxxx8]

@iain-anderson please add this issue to today's meeting agenda. we might need to decide whether we want to handle binary set command in this release.

[iain-anderson]

At the WG on 19th April, this is not priority for 2.0