Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error boundary #2579

Closed
nickofthyme opened this issue Jan 10, 2025 · 0 comments · Fixed by #2580
Closed

Remove error boundary #2579

nickofthyme opened this issue Jan 10, 2025 · 0 comments · Fixed by #2580
Assignees
Labels
:all Applies to all chart types :chart Chart element related issue enhancement New feature or request

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Jan 10, 2025

Is your feature request related to a problem? Please describe.

Currently it has come to our attention that the current error boundary in charts is not really used or needed.

Describe the solution you'd like

Chart consumers would like a way to catch errors that are thrown inside the chart and it's child components.

Currently we only catch so-called graceful errors and render the chart, or catch other errors and render a blank canvas.

Additional context

We should verify this works to render the outer error boundary in place of the chart, meaning the chart should not be rendered at all. Currently, it renders side-by-side...

Image

@nickofthyme nickofthyme added :all Applies to all chart types :chart Chart element related issue enhancement New feature or request labels Jan 10, 2025
@nickofthyme nickofthyme self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:all Applies to all chart types :chart Chart element related issue enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant