From 5ba8610000918c895710c1b3540a08c629fe9693 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Sat, 9 Nov 2024 14:26:47 -0500 Subject: [PATCH 1/5] Upgrade @typescript-eslint/* --- files/__addonLocation__/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/files/__addonLocation__/package.json b/files/__addonLocation__/package.json index 2be9a7f..0fd27d8 100644 --- a/files/__addonLocation__/package.json +++ b/files/__addonLocation__/package.json @@ -70,8 +70,8 @@ "@types/ember__template": "^4.0.7", "@types/ember__test": "^4.0.6", "@types/ember__utils": "^4.0.7", - "@typescript-eslint/eslint-plugin": "^7.7.1", - "@typescript-eslint/parser": "^7.7.1",<% } %> + "@typescript-eslint/eslint-plugin": "^8.13.0", + "@typescript-eslint/parser": "^8.13.0",<% } %> "@rollup/plugin-babel": "^6.0.4", "babel-plugin-ember-template-compilation": "^2.2.5", "concurrently": "^9.0.1", From 9dfd62a0ff42a333eda3b9023711dcf97bfbe231 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Sun, 10 Nov 2024 17:23:35 -0500 Subject: [PATCH 2/5] Upgrade eslint-plugin-ember --- files/__addonLocation__/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/files/__addonLocation__/package.json b/files/__addonLocation__/package.json index 0fd27d8..5e374ba 100644 --- a/files/__addonLocation__/package.json +++ b/files/__addonLocation__/package.json @@ -80,7 +80,7 @@ "ember-eslint-parser": "^0.4.2", <% } %>"eslint": "^8.56.0", "eslint-config-prettier": "^9.1.0", - "eslint-plugin-ember": "^12.2.1", + "eslint-plugin-ember": "^12.3.1", "eslint-plugin-import": "^2.30.0", "eslint-plugin-n": "^17.10.3", "eslint-plugin-prettier": "^5.2.1", From 3dafcd8008b463145569f95c3c15882f3009fbbf Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Sun, 10 Nov 2024 17:33:29 -0500 Subject: [PATCH 3/5] Remove hardcode for the ember-eslint-parser --- files/__addonLocation__/package.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/files/__addonLocation__/package.json b/files/__addonLocation__/package.json index 5e374ba..fd3b2bb 100644 --- a/files/__addonLocation__/package.json +++ b/files/__addonLocation__/package.json @@ -76,9 +76,8 @@ "babel-plugin-ember-template-compilation": "^2.2.5", "concurrently": "^9.0.1", "ember-source": "^5.4.0", - "ember-template-lint": "^6.0.0",<% if (packageManager === 'npm') { %> - "ember-eslint-parser": "^0.4.2", - <% } %>"eslint": "^8.56.0", + "ember-template-lint": "^6.0.0", + "eslint": "^8.56.0", "eslint-config-prettier": "^9.1.0", "eslint-plugin-ember": "^12.3.1", "eslint-plugin-import": "^2.30.0", From 04f78613b1edc9aaba4f59f787a0c5a476a36979 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Sun, 10 Nov 2024 17:53:57 -0500 Subject: [PATCH 4/5] New projects may not need this anyway -- instead of disabling lints, lets just let the user decide if they need it at all --- .../unpublished-development-types/index.d.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/files/__addonLocation__/unpublished-development-types/index.d.ts b/files/__addonLocation__/unpublished-development-types/index.d.ts index 1793551..45276a7 100644 --- a/files/__addonLocation__/unpublished-development-types/index.d.ts +++ b/files/__addonLocation__/unpublished-development-types/index.d.ts @@ -4,11 +4,11 @@ import '@glint/environment-ember-loose'; import '@glint/environment-ember-template-imports'; -declare module '@glint/environment-ember-loose/registry' { - // Remove this once entries have been added! 👇 - // eslint-disable-next-line @typescript-eslint/no-empty-interface - export default interface Registry { - // Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates) - // See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons - } -} +// Uncomment if you need to support consuming projects in loose mode +// +// declare module '@glint/environment-ember-loose/registry' { +// export default interface Registry { +// // Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates) +// // See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons +// } +// } From 2aa333f38285c113e43d077fca46d65a318135b7 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Sun, 10 Nov 2024 17:59:08 -0500 Subject: [PATCH 5/5] New projects may not need this anyway -- instead of disabling lints, lets just let the user decide if they need it at all --- files/__addonLocation__/src/template-registry.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/files/__addonLocation__/src/template-registry.ts b/files/__addonLocation__/src/template-registry.ts index 0758d89..7e1a8b0 100644 --- a/files/__addonLocation__/src/template-registry.ts +++ b/files/__addonLocation__/src/template-registry.ts @@ -4,8 +4,7 @@ // import type MyComponent from './components/my-component'; -// Remove this once entries have been added! 👇 -// eslint-disable-next-line @typescript-eslint/no-empty-interface -export default interface Registry { - // MyComponent: typeof MyComponent -} +// Uncomment this once entries have been added! 👇 +// export default interface Registry { +// MyComponent: typeof MyComponent +// }