Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

rake tasks do not play nicely with Rails Engine #1

Open
bogwro opened this issue Aug 7, 2013 · 1 comment
Open

rake tasks do not play nicely with Rails Engine #1

bogwro opened this issue Aug 7, 2013 · 1 comment

Comments

@bogwro
Copy link

bogwro commented Aug 7, 2013

In Rails Engine:

Rails.root

points to MyEngine/test/dummy folder.
However some of the paths are build based on the project's root folder like:

def self.vendor_dir
  File.join('vendor', 'assets', 'javascripts', 'rails_karma')
end

Also "vendor" folder does not exist in newly generated Rails Engine.

I think usage of:

File.join(Dir.pwd, 'path', 'to', 'folder')

would solve consistency of paths.

Please let me know.

Btw I used rails 3.2.14.

@joshuavial
Copy link
Member

I've only tested the gem against vanilla rails setup and aren't too familiar with rails engines. Next step is to get some tests going and after that I'm happy to look at making it work for rails engines.

I think the solution might be to skip the vendor dir entirely and just put all the libs in karma/lib

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants