Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document/surface what settings are applied when rt = NULL. #761

Closed
jamesmbaazam opened this issue Aug 29, 2024 · 2 comments · Fixed by #779
Closed

Document/surface what settings are applied when rt = NULL. #761

jamesmbaazam opened this issue Aug 29, 2024 · 2 comments · Fixed by #779

Comments

@jamesmbaazam
Copy link
Contributor

I've been thinking we should actually surface what settings are applied when rt = NULL. We only say that they can set it to NULL but we could add what settings are used when that is done. What do you think?

Originally posted by @jamesmbaazam in #747 (comment)

@seabbs
Copy link
Contributor

seabbs commented Aug 29, 2024

I think we might also want to move all the random walk + differencing etc settings. elsewhere (to i.e a latent argument). Then all models can use those features and we don't use anything by stealth. This would also mean getting rid of the gp arg (and passing it to the latent_opts as the model)

@jamesmbaazam
Copy link
Contributor Author

I think we might also want to move all the random walk + differencing etc settings. elsewhere (to i.e a latent argument). Then all models can use those features and we don't use anything by stealth. This would also mean getting rid of the gp arg (and passing it to the latent_opts as the model)

I'm all for exposing all settings that have been set under the hood. Looks like it deserves its own issue thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants