From 6135e20125d3cf436491c742789b0f46dde4bb25 Mon Sep 17 00:00:00 2001 From: Eralp Karaduman Date: Sat, 21 Aug 2021 03:47:11 +0300 Subject: [PATCH] Update readme --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index d41ffb6f37..7fea9bc844 100644 --- a/README.md +++ b/README.md @@ -51,10 +51,10 @@ I added a feature which automatically adds the latest PDF version download link This only works when automatic PDF version generation was set up (mentioned above). This is done by javascript running on the page, it tries to fetch github's API to get the last release. This link won't be generated in the PDF itself for several reasons; -- Lack of necessity, since you have the pdf there's need to download it again. -- I didn't want to deal with all the troubles coming with executing javascript in pdf generation context -- Travis CI blocks the request to github API i guess? -- I disabled javascript on wkhtmltopdf, see 2 reasons above. +- Lack of necessity, since you have the pdf there's no need to download it again. +- I didn't want to figure out the issues with executing javascript in pdf generation context +- ~~Travis CI blocks the request to github API i guess?~~ We don't use travis anymore, automation is moved to github actions +- I disabled javascript on wkhtmltopdf, see reasons above. ## Running jekyll locally