Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUOPC_CompAttributeIngest fails (quietly) if line has spaces #293

Open
danrosen25 opened this issue Sep 9, 2024 Discussed in #291 · 1 comment · May be fixed by #316
Open

NUOPC_CompAttributeIngest fails (quietly) if line has spaces #293

danrosen25 opened this issue Sep 9, 2024 Discussed in #291 · 1 comment · May be fixed by #316
Assignees
Labels
bug Something isn't working source: discussions

Comments

@danrosen25
Copy link
Member

danrosen25 commented Sep 9, 2024

Discussed in https://github.com/orgs/esmf-org/discussions/291

Using ESMF_Config with a list of items isn't working unless items do not have whitespace and are parsed in user code. Reproducer attached

What's broken

<COMP>_attributes::
      restart_fh = 0.05,0.25,0.5,3,6
 ::

Lists aren't working. This is seen as a single string.

<COMP>_attributes::
      restart_fh = 0.05, 0.25, 0.5, 3, 6
 ::

Spaces are breaking ESMF_Info. So NUOPC attributes doesn't store restart_fhat all. This is also true for restart_fh = "0.05, 0.25, 0.5, 3, 6".
reproducer_info.tar.gz

Issue Source

NUOPC_CompAttributeIngest does not ingest attributes from a NUOPC_FreeFormat if they do not have exactly 3 tokens. First token is the Info label, second token is =, third token is value up until first space. If a 4th token is found then it silently skips the line.

! Just skip these lines for now....

@danrosen25 danrosen25 self-assigned this Sep 9, 2024
@danrosen25 danrosen25 added the bug Something isn't working label Sep 9, 2024
@danrosen25 danrosen25 changed the title Floating point lists for NUOPC_CompAttributeGet NUOPC_CompAttributeIngest fails (quietly) if line has spaces Sep 9, 2024
danrosen25 added a commit to danrosen25/esmf that referenced this issue Oct 31, 2024
@danrosen25 danrosen25 linked a pull request Oct 31, 2024 that will close this issue
danrosen25 added a commit to danrosen25/esmf that referenced this issue Oct 31, 2024
@anntsay
Copy link

anntsay commented Dec 11, 2024

punt this to 8.9.. as we may consider a different implementation. for 8.8 will add documentation change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working source: discussions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants