-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing on token list in wallet simulator #11465
Comments
@wackerow @konopkja @nloureiro would be curious your thoughts on this |
we can lower text to 14 or 12 px to get some more space for the token amount row (dollar value keep 16, token value decrease) this in return should create more empty space from the bottom of the page hopefully |
we can do this also. this way we can reduce the box size from |
this solution will not work well once we show some amount of tokens there which we do later in another walkthrough increasing box siZes is possible, iam however afraid to do so because we know users on smaller devices will have hidden content but if its at the bottom and it is this particular information it can be ok. still would like to see option to reduce font size too |
this is when I decrease the font size: |
This issue is stale because it has been open 45 days with no activity. |
I think the original design here was intended to give the appearance of a list of tokens that would continue below the screen, hence the bottom margin was not needed. We're dealing with sizing constraints here, so personally would err on the side of not messing with it, but not against it if we form consensus around a decent alternative. |
@konopkja @nloureiro @MahendraBishnoi29 Do we know what next steps are here? |
Not a strong take here; maybe the reduced font size proposed by @MahendraBishnoi29 can be a good way to go |
alright then, i'll submit a PR soon with my solution @wackerow |
Describe the bug
In the
Create account
andSend/receive tokens
flows of the wallet simulator, the spacing of the tokens list (UNI token in this case) is quite close to the border. Without scrolling for more tokens in this list, the spacing looks a bit awkward.To reproduce
Create account
orSend/receive tokens
tutorialsExpected behavior
Little more padding on the token list
Screenshots
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: