Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing on token list in wallet simulator #11465

Closed
2 tasks
corwintines opened this issue Oct 18, 2023 · 11 comments · Fixed by #13202
Closed
2 tasks

Spacing on token list in wallet simulator #11465

corwintines opened this issue Oct 18, 2023 · 11 comments · Fixed by #13202
Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes design All the issues related to design should use this tag question ❓ Further information is requested

Comments

@corwintines
Copy link
Member

Describe the bug

In the Create account and Send/receive tokens flows of the wallet simulator, the spacing of the tokens list (UNI token in this case) is quite close to the border. Without scrolling for more tokens in this list, the spacing looks a bit awkward.

To reproduce

  1. Go to https://ethereum.org/en/wallets/#sim
  2. Select either the Create account or Send/receive tokens tutorials
  3. When you get to a screen with a token list, you can see the UNI token spacing looks a bit awkward without any scrolling

image

Expected behavior

Little more padding on the token list

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@corwintines corwintines added the bug 🐛 Something isn't working label Oct 18, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Oct 18, 2023
@corwintines
Copy link
Member Author

@wackerow @konopkja @nloureiro would be curious your thoughts on this

@konopkja
Copy link
Contributor

konopkja commented Oct 18, 2023

we can lower text to 14 or 12 px to get some more space for the token amount row (dollar value keep 16, token value decrease)

this in return should create more empty space from the bottom of the page hopefully

@MahendraBishnoi29
Copy link
Contributor

MahendraBishnoi29 commented Oct 20, 2023

how about if we increase the size of the box a little bit? it was 600px and I tried 610px. also assign this to me 😉

image

@MahendraBishnoi29
Copy link
Contributor

we can do this also. this way we can reduce the box size from 600px to 570px. @konopkja @corwintines

image

@konopkja
Copy link
Contributor

we can do this also. this way we can reduce the box size from 600px to 570px. @konopkja @corwintines

image

this solution will not work well once we show some amount of tokens there which we do later in another walkthrough

increasing box siZes is possible, iam however afraid to do so because we know users on smaller devices will have hidden content but if its at the bottom and it is this particular information it can be ok.

still would like to see option to reduce font size too

@MahendraBishnoi29
Copy link
Contributor

we can do this also. this way we can reduce the box size from 600px to 570px. @konopkja @corwintines
image

this solution will not work well once we show some amount of tokens there which we do later in another walkthrough

increasing box siZes is possible, iam however afraid to do so because we know users on smaller devices will have hidden content but if its at the bottom and it is this particular information it can be ok.

still would like to see option to reduce font size too

this is when I decrease the font size:

image

Copy link
Contributor

github-actions bot commented Dec 5, 2023

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Dec 5, 2023
@wackerow
Copy link
Member

@wackerow @konopkja @nloureiro would be curious your thoughts on this

I think the original design here was intended to give the appearance of a list of tokens that would continue below the screen, hence the bottom margin was not needed.

We're dealing with sizing constraints here, so personally would err on the side of not messing with it, but not against it if we form consensus around a decent alternative.

@wackerow
Copy link
Member

@konopkja @nloureiro @MahendraBishnoi29 Do we know what next steps are here?

@wackerow wackerow added question ❓ Further information is requested design required 🎨 This involves design changes design All the issues related to design should use this tag and removed Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels Jun 13, 2024
@nloureiro
Copy link
Contributor

Not a strong take here; maybe the reduced font size proposed by @MahendraBishnoi29 can be a good way to go

@MahendraBishnoi29
Copy link
Contributor

Not a strong take here; maybe the reduced font size proposed by @MahendraBishnoi29 can be a good way to go

alright then, i'll submit a PR soon with my solution @wackerow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working design required 🎨 This involves design changes design All the issues related to design should use this tag question ❓ Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants