Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create story for BannerNotification component #14152

Open
4 tasks
Tracked by #13043
corwintines opened this issue Oct 10, 2024 · 4 comments
Open
4 tasks
Tracked by #13043

Create story for BannerNotification component #14152

corwintines opened this issue Oct 10, 2024 · 4 comments
Assignees
@prxjwal
Labels
dev required This requires developer resources hacktoberfest Track hacktoberfest activity

Comments

@corwintines
Copy link
Member

corwintines commented Oct 10, 2024 •
edited
Loading

Create story tests for BannerNotification component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Move /src/components/Banners/BannerNotification.tsx to /src/components/Banners/BannerNotification/index.tsx
  • Fix any filepath changes to imports for the BannerNotification component
  • Create story file /src/components/Banners/BannerNotification/BannerNotification.stories.tsx
  • Write story testing render of the BannerNotification component in context of use.
@corwintines corwintines mentioned this issue Oct 10, 2024
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Oct 10, 2024
@corwintines corwintines changed the title BannerNotification Create story for BannerNotification component Oct 10, 2024
@corwintines corwintines added dev required This requires developer resources hacktoberfest Track hacktoberfest activity and removed needs triage 📥 This issue needs triaged before being worked on labels Oct 10, 2024
@corwintines
Copy link
Member Author

@prxjwal could you comment here so I can assign :)

@prxjwal
Copy link

prxjwal commented Oct 11, 2024

@corwintines hey thanks pls assign me this issue

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 14, 2024
@GovardhaneNitin
Copy link

Create story tests for BannerNotification component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Move /src/components/Banners/BannerNotification.tsx to /src/components/Banners/BannerNotification/index.tsx
  • Fix any filepath changes to imports for the BannerNotification component
  • Create story file /src/components/Banners/BannerNotification/BannerNotification.stories.tsx
  • Write story testing render of the BannerNotification component in context of use.

Hi! I'm interested in working on this issue. I'd like to implement the Storybook component for BannerNotification.

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prxjwal prxjwal

Labels
dev required This requires developer resources hacktoberfest Track hacktoberfest activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@corwintines @prxjwal @GovardhaneNitin