From 21dce0f4bacac549d15d31c099958084d4087a79 Mon Sep 17 00:00:00 2001 From: Patrick Mihelich Date: Fri, 13 Dec 2024 16:47:35 -0600 Subject: [PATCH] Use a consistent ubuntu across all Linux CI jobs. Rollout of ubuntu-24.04 as ubuntu-latest broke our Python CI due to newer and stricter GCC. Mitigate by using ubuntu-20.04, matching what we currently use for the PyPI release. --- .github/workflows/ci_python.yml | 2 +- .github/workflows/docs.yml | 2 +- .github/workflows/format.yml | 2 +- .github/workflows/pypi-release.yml | 4 ++-- .github/workflows/release.yml | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci_python.yml b/.github/workflows/ci_python.yml index fed1494b..00f0c608 100644 --- a/.github/workflows/ci_python.yml +++ b/.github/workflows/ci_python.yml @@ -18,7 +18,7 @@ jobs: # 1. they removed support for python 3.8 & 3.9 on macos-14 (now macos-latest) # - See: https://github.com/actions/setup-python/issues/696#issuecomment-2071769156 # 2. `test_pose` fails on macos-13 and macos-14 (but not macos-12) - os: [ubuntu-latest, macos-12] + os: [ubuntu-20.04, macos-12] python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index c92ad7b9..25f92b1c 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -12,7 +12,7 @@ on: jobs: deploy: name: Deploy to GitHub Pages - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 with: diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml index 7a916a0f..af3e150b 100644 --- a/.github/workflows/format.yml +++ b/.github/workflows/format.yml @@ -14,7 +14,7 @@ concurrency: jobs: pre-commit-check: - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 - uses: actions/setup-python@v3 diff --git a/.github/workflows/pypi-release.yml b/.github/workflows/pypi-release.yml index ab4b6ac0..0db671da 100644 --- a/.github/workflows/pypi-release.yml +++ b/.github/workflows/pypi-release.yml @@ -41,7 +41,7 @@ jobs: build_sdist: name: Build source distribution - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v4 - name: Build sdist @@ -52,7 +52,7 @@ jobs: upload_pypi: needs: [build_wheels, build_sdist] - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 if: github.event_name == 'release' && github.event.action == 'published' steps: - uses: actions/download-artifact@v3 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 798ca7db..a67f9c91 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,7 +13,7 @@ jobs: # Based on https://dev.to/eugenebabichenko/automated-multi-platform-releases-with-github-actions-1abg create_release: name: Create Release and Provide Upload URL. - runs-on: ubuntu-latest # OS to create release, not for build + runs-on: ubuntu-20.04 # OS to create release, not for build outputs: # This job will provide URL for build jobs to use for uploading assets upload_url: ${{ steps.create_release.outputs.upload_url }}