-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks are incorrect #8
Comments
This line make Deno http server serves around 25-40% less req/sec than that of Node.js Instead of using it, use code samples from the deno website
|
This line is from code which Deno uses to benchmark itself
Fastro should use benchmarking code used by Deno, and not from the code examples. For whoever reading this, it's visible from responses on #6 and #8 that fastro maintainers are not interested in sharing the real benchmarks and want to just boast about fake benchmarks. It won't help in the long run, and gives a bad name for Deno community. Good news is that there are some serious players among Deno web frameworks (like drash) who take the responsibility drashland/drash#322 |
@trivikr this benchmark is only to compare the speed of displaying 'hello-world'. btw, I already update and move the benchmark to https://github.com/fastrodev/fastrodev.github.io/blob/master/benchmarks/deno_http.ts the speed becomes a little slower. |
Describe the bug
The benchmarks shared in https://github.com/fastrodev/fastro#benchmarks are incorrect.
Deno http server serves around 25-40% less req/sec than that of Node.js denoland/deno#6722 (comment)
To Reproduce
Rerun benchmarks by returning date and connection headers in Deno/Fastro just like it's done in:
Expected behavior
Deno/fastro will serve around 25-40% less req/sec when compared to that of Node.js/Fastify
The text was updated successfully, but these errors were encountered: