-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon Request: Currency #182
Comments
Could you be more specific about which currency icons you'd like? USD? Euro? Screenshots would be super helpful 😊 |
Would love currency symbols! |
Sup this. |
A dollar icon would be super useful. It's general enough to accommodate a good number of use cases. |
In addition to the dollar-sign it would be very nice to add EUR as well. Thanks a lot! |
I really need a pound sterling GBP £ icon British currency ;) |
Missing the INR icon (₹), waiting for it to be added in next release quickly. |
I still miss a Euro sign € |
@locness3 @colebemis @dags170291 @kumarharsh @LittleGyaani @Jolievin How does this look? I have designed INR and GBP icons! Do you guys have any other currency icons that you want me to design? EDIT: Have also added the Japanese Yen symbol! |
I have updated the EUR icon! Figma
|
Both look perfect! |
Great @locness3 ... i'm going to add all of these icons and open a PR! |
Hey everyone, I redid the BTC (bitcoin) icon ... what does everyone think? cc @locness3 @ahtohbi4
|
Great! |
Any updates on this? |
@J0XX0 We need to get @colebemis to merge #670 |
No update? |
No. |
Hello, everyone |
Yup, ₹ looks cool! |
@jletey, nice work! I'll send the missing icons then |
@scodeler unfortunately you have about a 0% that your addition will get merged. This repository |
I understand why you feel this way, @J0XX0, but it being unmaintained doesn't make it suck; rather, @colebemis doesn't have time to review submissions as he would like to, to keep it good quality. Please do not hate. |
Would some folks volunteer to maintain a fork with the icons submitted? |
Maybe not suck, but does make it useless. 300 icons vs 800+ icons on fontawesome & endless icons on flaticon.com Much better to source your own SVGs considering much are not included anyways, such as currency; a crucial and very popular icon. Why does it take so much time to merge a simple PR? Just my opinion. Not hate, just criticism. P.S.: This PR / issue is open for about 3 years... Kind of sad imo, an icon framework needs to iterate quick. Fontawesome is pushing out a new icon set every year... P.P.S.: Don't get me wrong, if the moderation issue gets fixed Feather Icons could defo be No.1 icon framework. It just frustates me that I've chosen an icon pack, just need to use a currency icon and then it's not available & a perfect well-created PR is open since 2017. I hope #893 will help out the repo! I'm available for help as well. |
I have, and still would love too! |
You know, you can use the SVGs from PRs ;)
Fontawesome have more people, and they also sell stuff, where Feather is free and maintained by 1 person.
wdym "have"? |
|
I'm talking about maintaining a seperate fork :) |
@locness3 I have gone ahead and created a fork and invited you and @ahtohbi4 to maintain it :) Might be best to create an org? I've also deployed the existing site to feather.now.sh, so we have that URL as well. Not entirely quite sure the best way to move forward with the PRs, as the PRs don't transfer :/ |
I think we should ask ppl to redo their PRs for the fork |
Also, where does the site deploy from? |
I agree 👍
Right now it's being deployed from Vercel - the code is all local, I deployed quickly so that no-one would steal the feather.now.sh domain 😅 I will be pushing some a "v2" of the site to my repo soon. A redesign, but most importantly, loading the icons from the |
Yeah, please put the site in the repo |
@locness3 You can follow along here: https://github.com/jletey/feather/pull/1 😄 |
This is correct for INR - Rupee |
please add Naira sign too |
Naira sign is pretty basic
|
The € still hasn't been added to the library, is someone working on this? |
consider using https://lucide.dev, it has that icon |
I'm Currently working on a branding project I love just how these icons look with the resume in my project. it would be awesome if I can get a set of currency icons that is uniform with the rest of my project thanks.
The text was updated successfully, but these errors were encountered: