-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon Request: Column #565
Comments
This is already done!! Use the "layout" icon! |
@mhosman as I said, I made this icon mockup from the layout icon. I'm interested in an icon with 2 equal columns to represent a split screen, not one that appears as a sidebar and a header of a page like the layout icon does. (original)versus (the new requested version) |
I figured out how to use Figma and used the styleguides listed in #171 to make it on my own. Here is a screenshot of the pixel layout: And here is the exported SVG: Hope I went through the right process to get this added! |
@csandman Do you think the "header" is necessary for a |
@colebemis I think the header helps to show that its a type of page layout but if you'd rather the more minimalist look, that would work too. By the way, in the future would it be helpful to include a .fig file with the svg to make it easier to modify? |
@csandman Yeah, I think I prefer the minimal version (without the header). Do you wanna try opening a PR? There are instructions on how to do that at the bottom of this comment: #171 (comment) I can walk you through it in more detail if those instructions are a little confusing. Also, in the future, a figma link or |
@colebemis I would love to submit a pull request! It will be my first one on an open source project. Would you prefer I name it column or columns? Also, in order to do so I should for the repo, push to that, and then submit the pull request, correct? EDIT I made the changes to remove the header also |
@csandman I left a comment on the PR 👍 |
Icon Request: column
Here is a sample I made by slightly modifying your layout icon, it should be very easy to replicate. I simply moved the top bar up and centered the vertical line.
Here is the version from font-awesome:
https://fontawesome.com/icons/columns?style=solid
If you can find the time, please add this one! It should take long to make and it would be what pushes me over the edge to using this icon pack!
The text was updated successfully, but these errors were encountered: