Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off CLI #175

Open
3 tasks
nphilipp opened this issue Aug 30, 2024 · 2 comments
Open
3 tasks

Split off CLI #175

nphilipp opened this issue Aug 30, 2024 · 2 comments
Assignees
Labels
buildsystem Something affecting build systems cpe This ticket needs attention of CPE team dependencies Affecting dependencies deployment Affecting deployment of the package scope This makes code better focussed tracking External work to be tracked UI/UX Related to how users interact with the program

Comments

@nphilipp
Copy link
Member

nphilipp commented Aug 30, 2024

Story

As an operator of build infrastructure,
I want the dependency footprint of rpmautospec to be small,
so that bootstrapping is easier.

Acceptance Criteria

  • The rpmautospec Python package can be installed without pulling in click and related packages.
  • Tests involving the CLI are skipped if click e.a. aren’t available.
  • Fedora/EPEL packages enable switching off the offending bits for bootstrapping.
@nphilipp nphilipp converted this from a draft issue Aug 30, 2024
@nphilipp nphilipp added buildsystem Something affecting build systems UI/UX Related to how users interact with the program scope This makes code better focussed dependencies Affecting dependencies deployment Affecting deployment of the package tracking External work to be tracked labels Aug 30, 2024
@hroncok
Copy link
Contributor

hroncok commented Sep 10, 2024

Getting rid of the click dependency might be a better alternative then separating this to a third package.

@nphilipp nphilipp added the cpe This ticket needs attention of CPE team label Sep 12, 2024
@nphilipp nphilipp assigned nphilipp and unassigned nphilipp Nov 13, 2024
@nphilipp nphilipp assigned nphilipp and unassigned nphilipp Nov 22, 2024
@nphilipp
Copy link
Member Author

Getting rid of the click dependency might be a better alternative then separating this to a third package.

Sorry for the late reply. My idea was to leave CLI code in the package, but keep it suitably separate so that koji, mock e.a. can do the equivalent of rpmautospec process-distgit … without click (which should really just be necessary for use by humans). One reason for the switch to click was relatively easy command line completion, the other was that argparse is not a joy to use in comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildsystem Something affecting build systems cpe This ticket needs attention of CPE team dependencies Affecting dependencies deployment Affecting deployment of the package scope This makes code better focussed tracking External work to be tracked UI/UX Related to how users interact with the program
Projects
Development

No branches or pull requests

2 participants