Gigantic CPU spikes when opening settings window

[OwlCacone]

Description

CPU usage spikes up to almost 90% when opening the settings window for Files.
For context, I am using a old CPU, a i3-9100F to be exact.

Steps To Reproduce

1. Open Files
2. Open the top right settings menu, represented by a cog icon
3. Check CPU activity in task manager

Requirements

• e.g. Have Files not use almost the entire CPU's resources when opening the settings window

Files Version

2.5.21.0

Windows Version

10.0.19045.3570

Log File

debug.log

[Josh65-2201]

Thanks for the report, can you see if this is an issue in the preview version. https://files.community/download

[OwlCacone]

Sure thing, I'll post my results in a bit

[OwlCacone]

In the Preview build, the settings window utilizes a lot less of the CPU's resources, around 15% at peak.

Though, I did notice that quickly clicking through folders in the Favorites tab shot the CPU usage up to around 50% at peak.
This is still a gigantic improvement, but why would the program use so many resources just for switching folders?

[Josh65-2201]

Files has to load the contents of that folder and if you have Files settings > Folders > Calculate folder sizes enabled it uses more. General performance improvements are being made and tracked in #4180.