Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhanced logging option #15

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

n1nj4888
Copy link

Hi @frdmn,

I created this PR for enhanced logging as per my feature request (Issue #13) to add the option (SPEEDTEST_ENHANCED_LOGGING) to output all the speedtest-cli metrics to a single influx measurement (INFLUX_MEASUREMENT).

If SPEEDTEST_ENHANCED_LOGGING is not set, the code should work as it does currently writing the download, upload and ping metrics only to InfluxDB. If SPEEDTEST_ENHANCED_LOGGING is set then the code should work in the new way and log all speedtest-cli results to a single measurement (INFLUX_MEASUREMENT) - Obviously if SPEEDTEST_ENHANCED_LOGGING is set, the grafana dashboard will have to be amended. I haven't got around to doing this yet but have my own dashboard and it seems to work well...

This is my first PR and I'm not a developer by profession so there will likely be a better way to do some of this?

Thanks!

@jeanfrancoislarente
Copy link

@n1nj4888 - you should provide a default dashboard with the enhanced metrics!
I would take it for a test drive and report my experience here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants