Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @frdmn,
I created this PR for enhanced logging as per my feature request (Issue #13) to add the option (SPEEDTEST_ENHANCED_LOGGING) to output all the speedtest-cli metrics to a single influx measurement (INFLUX_MEASUREMENT).
If SPEEDTEST_ENHANCED_LOGGING is not set, the code should work as it does currently writing the download, upload and ping metrics only to InfluxDB. If SPEEDTEST_ENHANCED_LOGGING is set then the code should work in the new way and log all speedtest-cli results to a single measurement (INFLUX_MEASUREMENT) - Obviously if SPEEDTEST_ENHANCED_LOGGING is set, the grafana dashboard will have to be amended. I haven't got around to doing this yet but have my own dashboard and it seems to work well...
This is my first PR and I'm not a developer by profession so there will likely be a better way to do some of this?
Thanks!