Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh of this Docker Stack #29

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

Refresh of this Docker Stack #29

wants to merge 18 commits into from

Conversation

iamk3
Copy link

@iamk3 iamk3 commented Dec 17, 2021

Hi @frdmn

This is my first official large PR anyway. I found your stack and thought it was great! I wanted to build it myself to try it out and ran into issues. The main one being that bintray had been sunset by JFrog.

Updated:

  • Speedtest container now using Debian 11 and following the new instructions put out by Ookla. I was able to build the container and push it to https://hub.docker.com/r/iamk3/docker-speedtest-grafana if you'd like to test it.
  • Updated the docker-compose.yml to use the newest version of Grafana to mitigate some security issues that might exist in the older version.
  • Updated the docker-compose.yml to use my current updated version of the speedtest container. I'd love for you to build and push it to yours as you are the originator!
  • Updated index.js to now include Jitter stats
  • Updated speedtest.json dashboard to display jitter and other additional stats.
  • Updated README in a few places.

Lastly, I am not a dev and am still learning, so any feedback would be appreciated if needed! Thanks!

@SamHerts
Copy link

SamHerts commented Nov 2, 2022

Great changes

iamk3 added 4 commits June 14, 2023 11:32
@frdmn
Copy link
Owner

frdmn commented Jun 14, 2023

Sorry for the lack of attention on this - this looks superb! ❤️

I'll try to review this ASAP.

@iamk3
Copy link
Author

iamk3 commented Jun 14, 2023

Thank you for getting back! I realize that "real" jobs can get in the way. haha...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants