-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh of this Docker Stack #29
Open
iamk3
wants to merge
18
commits into
frdmn:dev
Choose a base branch
from
iamk3:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… since bintray no longer exists.
based on dashboard created at annedobalina/docker-speedtest-grafana
added jitter
updated dashboard screenshot
Great changes |
Consistent naming of containers Updated speedtest to latest version
Small refactoring changes
Sorry for the lack of attention on this - this looks superb! ❤️ I'll try to review this ASAP. |
Thank you for getting back! I realize that "real" jobs can get in the way. haha... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @frdmn
This is my first official large PR anyway. I found your stack and thought it was great! I wanted to build it myself to try it out and ran into issues. The main one being that bintray had been sunset by JFrog.
Updated:
Lastly, I am not a dev and am still learning, so any feedback would be appreciated if needed! Thanks!