Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and decide what the unknown dimension does in geo-traits #1251

Open
frewsxcv opened this issue Nov 1, 2024 · 5 comments
Open

Clarify and decide what the unknown dimension does in geo-traits #1251

frewsxcv opened this issue Nov 1, 2024 · 5 comments

Comments

@frewsxcv
Copy link
Member

frewsxcv commented Nov 1, 2024

There was some discussion in Discord, but I also want to track this issue in GitHub. Should this block a geo-traits 0.2.0 release?

@kylebarron
Copy link
Member

Perhaps we should make a little progress here before 0.2.0

@frewsxcv
Copy link
Member Author

Relevant discussion: georust/geojson#245 (comment)

@kylebarron
Copy link
Member

Consolidating discussion here from georust/geojson#245

I would prefer not having dim return Option, because I think it's unreasonable to ask every consumer to check for a null dimension.

In the GeoJSON case, it would only apply to empty geometries. How wrong would it be to pass on Unknown(2), or something like that. The GeoJSON geometry is empty, so it could have two dimensions. Maybe lying in a way that could be true in very rare circumstances is better than making every reader consider None

@frewsxcv
Copy link
Member Author

For the time being, that seems alright to me. In which case, that wouldn't require any changes to the current dimensions implementation, right?

@kylebarron
Copy link
Member

kylebarron commented Nov 21, 2024

Correct I believe, and then we can continue the discussion after 0.2 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants