-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InvalidGeometryConversion should have "expected" vs. "found" types. #201
Comments
I think this is a good idea. The former limits control over resource usage just to print an error. Could blow up log messages, etc. |
Another options would be to still allow the incompatible geometry to remain as-is so it's available to error handlers, but change the error reporting message to not |
2 tasks
bors bot
added a commit
that referenced
this issue
Aug 22, 2022
202: Added borrowed value conversion traits for geo_types. r=michaelkirk,urschrei a=metasim - [X] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [X] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Reworked current implementation to use borrowed values, and created macro to generate owned value variants that delegate to the borrowed value ones. Note: Until #201 is addressed, invalid geometry conversions will be cloned during error reporting. Co-authored-by: Simeon H.K. Fitch <fitch@astraea.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when trying to convert from a geojson geometry to an incompatible geo-type (e.g. a Point to a LineString) we use this error:
But instead, I think it'd be more helpful as
The text was updated successfully, but these errors were encountered: