Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain websites are not saved properly #1603

Open
mikkovedru opened this issue Oct 27, 2024 · 3 comments
Open

Certain websites are not saved properly #1603

mikkovedru opened this issue Oct 27, 2024 · 3 comments
Labels

Comments

@mikkovedru
Copy link
Contributor

Describe the bug
Certain websites are not saved properly

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://sprint.mnogosdelal.ru' or 'https://notes.mnogosdelal.ru'.
  2. Save them.
  3. Check the result.

Screenshots
How the first link looks in browser:
image

How the saved version looks like:
image

Environment

  • OS: Linux Mint 21.3 Cinnamon
  • Browser: Firefox 131.0.3
@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Oct 27, 2024

Thank you for the bug report. This is due to the option Images > save deferred images. I will try to find the cause of this issue. I've already seen it sometimes in ads but they are hard to debug.

FYI, the easiest way to circumvent this issue is to scroll down to the bottom of the page (this action will disable the option) and save the page with SingleFile.

@mikkovedru
Copy link
Contributor Author

mikkovedru commented Oct 27, 2024

FYI, the easiest way to circumvent this issue is to scroll down to the bottom of the page (this action will disable the option) and save the page with SingleFile.

This seemed to work with the first link, but not with the second one ('notes.mnogosdelal.ru').

Edit:
the recommendation also didn't work with:

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Oct 29, 2024

I cannot reproduce the issue when scrolling to the bottom of the page (or disabling Images > save deferred images) with all the links you provided.

The issue is due to the fact that these sites want to display an image covering the whole screen (e.g. 100vh in CSS) and that the screen height when save deferred images is active is approx 15,000px (i.e. the height of the page). These sites don't take into account the width of the page to compute the zoom level and have not been designed for (very) large vertical screens. The issue can also be reproduced without SingleFile by emulating a mobile device in the Dev Tools and setting a large screen height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants