Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New msys2-runtime version] Cygwin: FILE_OPEN_NO_RECALL is incompatible with FILE_DIRECTORY_FILE #4897

Closed
github-actions bot opened this issue Apr 6, 2024 · 2 comments

Comments

@github-actions
Copy link

github-actions bot commented Apr 6, 2024

Cygwin: FILE_OPEN_NO_RECALL is incompatible with FILE_DIRECTORY_FILE

If FILE_DIRECTORY_FILE is given, FILE_OPEN_NO_RECALL is not allowed,
otherwise NtCreateFile returns STATUS_INVALID_PARAMETER.

Drop FILE_OPEN_NO_RECALL where FILE_DIRECTORY_FILE is specified.

Fixes: f6b56abec186 ("Cygwin: try to avoid recalling offline files")
Reported-by: Bruce Jerrick <bmj001@gmail.com>
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

msys2/msys2-runtime@260676c

@rimrul rimrul closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
@rimrul
Copy link
Member

rimrul commented Apr 7, 2024

Superseeded by #4898

@dscho
Copy link
Member

dscho commented Apr 7, 2024

This is only necessary because of the better OneDrive support, which we haven't yet merged. I integrated the follow-up into git-for-windows/msys2-runtime#69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants