From 5130a2e0d260e3afb9c7815c57be77f506244c72 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Filip=20Tron=C3=AD=C4=8Dek?= <filip@gitpod.io>
Date: Mon, 2 Oct 2023 09:32:54 +0200
Subject: [PATCH] Node 19 -> Node 20 (#1187)

---
 CHANGELOG.md                | 4 ++++
 chunks/lang-node/chunk.yaml | 4 ++--
 dazzle.yaml                 | 2 +-
 tests/lang-node.yaml        | 6 +++---
 4 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 446ac6576..a4b13586d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 A curated, chronologically ordered list of notable changes in [Gitpod's default workspace images](https://hub.docker.com/u/gitpod).
 
+## 2023-10-02
+
+- For `workspace-node`, deprecate Node 19 in favor of Node 20
+
 ## 2023-09-18
 
 - Bump Rust to `1.72.0`
diff --git a/chunks/lang-node/chunk.yaml b/chunks/lang-node/chunk.yaml
index 0e461582f..0c9a5f08a 100644
--- a/chunks/lang-node/chunk.yaml
+++ b/chunks/lang-node/chunk.yaml
@@ -2,6 +2,6 @@ variants:
   - name: "18"
     args:
       NODE_VERSION: 18.18.0
-  - name: "19"
+  - name: "20"
     args:
-      NODE_VERSION: 19.9.0
+      NODE_VERSION: 20.8.0
diff --git a/dazzle.yaml b/dazzle.yaml
index 350f555a7..88d792dab 100644
--- a/dazzle.yaml
+++ b/dazzle.yaml
@@ -64,7 +64,7 @@ combiner:
       ref:
       - base
       chunks:
-        - lang-node:19
+        - lang-node:20
         - tool-chrome
     - name: node-lts
       ref:
diff --git a/tests/lang-node.yaml b/tests/lang-node.yaml
index 5822c281f..3eeed93d1 100644
--- a/tests/lang-node.yaml
+++ b/tests/lang-node.yaml
@@ -4,7 +4,7 @@
   assert:
   - status == 0
   - stdout.indexOf("v18")  != -1 ||
-    stdout.indexOf("v19")  != -1
+    stdout.indexOf("v20")  != -1
 - desc: it should have yarn
   command: [yarn --version]
   entrypoint: [bash, -i, -c]
@@ -20,12 +20,12 @@
   entrypoint: [bash, -i, -c]
   assert:
   - status == 0
-- desc: it should yarn work
+- desc: it should have working yarn
   command: [yarn global add envinfo]
   entrypoint: [bash, -i, -c]
   assert:
   - status == 0
-- desc: it should pnpm work
+- desc: it should have working pnpm
   command: [pnpm i -g envinfo]
   entrypoint: [bash, -i, -c]
   assert: