Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Command Completion key bindings #347

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Auto Command Completion key bindings #347

wants to merge 3 commits into from

Conversation

ampresent
Copy link

Does anyone find Auto Command Completion annoying as me ?

I add/altered 3 features:

On Auto Command Completion displaying,

  1. Press Enter to send '\n' to psudo-tty
  2. Press ^Enter to select row
  3. Press ^C to close Auto Command Completion window

press ^Enter to select row,
and press Enter to send '\n' to psudo-tty.
otherwise ^C is not interpreted by NSView.
@ampresent
Copy link
Author

https://superuser.com/questions/1089955/disable-autocomplete-hints-on-iterm2

Comments below may suffer from similar problems. I do too.

Maybe configuration is an option, in case anyone in favor of existing behavior ?

@ampresent ampresent changed the title Alter auto comp select Auto Command Completion key bindings Dec 7, 2017
@ampresent
Copy link
Author

ampresent commented Dec 8, 2017

I noticed, it might be better if I replace ^Enter with Tab, and if I let ^C not only close popup but also send kill.

Tab should remain working for shell completion, I think.

@gnachman
Copy link
Owner

I think this is a good improvement, but the change from Enter to Control-Enter is going to be hard for users to discover. What about using right-arrow instead?

Also, please put this behind a configuration flag. I prefer to test out such changes on beta users to see how it's received. Add a setting to the "Experimental Features" section of iTermAdvancedSettingsModel.[hm], enabled by default for beta users. Look for supportREPCode, which already does this. Make the new behavior conditional on its being enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants