Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable error handler #326

Open
EwenQuim opened this issue Dec 30, 2024 · 5 comments
Open

Disable error handler #326

EwenQuim opened this issue Dec 30, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@EwenQuim
Copy link
Member

Add an Engine option to replace the default error handler by a simple pass-through func (err error) error {return err}

@EwenQuim EwenQuim added the good first issue Good for newcomers label Dec 30, 2024
@dylanhitt
Copy link
Collaborator

dylanhitt commented Dec 30, 2024

Could not be easily accomplished with this

#320

@dylanhitt
Copy link
Collaborator

Or is the idea that we provide both? Removing the functionality of #320 would be rather disruptive.

@EwenQuim
Copy link
Member Author

We can provide both, second one as a shortcut. But yeah, waiting for linked PR to be merged (should be soon)

@Mankeylol
Copy link

Mind if I try this one?

@dylanhitt
Copy link
Collaborator

Hey, feel free to assign the issue to yourself. You probably want to base your work on #302 as the ErrorHandler is migrating to the Engine struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants