Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer PR authorship #32939

Open
jpraet opened this issue Dec 21, 2024 · 2 comments
Open

Transfer PR authorship #32939

jpraet opened this issue Dec 21, 2024 · 2 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/pr Issues related to pull requests type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@jpraet
Copy link
Member

jpraet commented Dec 21, 2024

Feature Description

It would be useful if the author of a PR could transfer the PR to another author.

It is not uncommon for PR's to be handed over to be completed by another developer.
When that happens, there are currently some problems:

  • the new developer that is working on the PR can now approve his own work, this is not right
  • the original author of the PR cannot approve / reject the PR, even though it's not really theirs anymore

See also related discussion https://github.com/orgs/community/discussions/15067

Screenshots

No response
@jpraet jpraet added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/pr Issues related to pull requests labels Dec 21, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 21, 2024 •
edited
Loading

It sounds a good feature but it is very difficult to make it completely right with some simple approaches, I can see a lot of edge cases.

IMO the clearest workflow should be "close the old one and let the new author start a new one".

@lunny
Copy link
Member

lunny commented Dec 21, 2024

If the head branch came from a fork repo, the new author may have no permission to push code

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/pr Issues related to pull requests type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @wxiaoguang @jpraet